[PATCH 00/33] Use common macro to define resources

Jean-Christophe PLAGNIOL-VILLARD plagnioj at jcrosoft.com
Wed Apr 25 06:10:07 EDT 2012


On 09:38 Wed 25 Apr     , Heiko Stübner wrote:
> Hi,
> 
> Am Mittwoch, 25. April 2012, 06:19:39 schrieb Jean-Christophe PLAGNIOL-
> VILLARD:
> > On 09:42 Wed 25 Apr     , Tushar Behera wrote:
> > > There are some helper macros (DEFINE_RES_XXX) for defining resource
> > > structures. This patchset migrates all the earlier resource
> > > definitions (within Samsung specific code base) to use these macros.
> > > 
> > > In some cases, it was not possible to use DEFINE_RES_IRQ() macro because
> > > of usage of additional flags. In those cases, DEFINE_RES_NAMED() macro
> > > is used instead.
> > > 
> > > The patches are rebased on top of Kukjin's for-next branch at this
> > > commit.
> > > 
> > > d0ee53a Merge branch 'next/board-samsung' into for-next
> > 
> > is this really necessary as we switch to DT this code will be droped
> 
> As far as I know legacy SoCs are allowed to keep being non-DT and I don't see 
> the older Samsung SoCs (especially the S3C24XX ones) changing to DT anytime 
> soon, as they don't see any new development but only bug fixes currently.
> 
> 
> > for my point of view it's cosmetics change
> it is, but it also makes the code more readable
we get comment from Linus to do not do cosmetic changes

so if it work well I'll not touch it

Best Regards,
J.



More information about the linux-arm-kernel mailing list