[PATCH 06/19] ARM: OMAP4: Auto generate SAR layout contents
Tony Lindgren
tony at atomide.com
Tue Apr 24 12:37:34 EDT 2012
* Tero Kristo <t-kristo at ti.com> [120420 02:38]:
> -void omap4_sar_overwrite(void)
> +void omap_sar_overwrite(void)
> {
> u32 val = 0;
> - u32 offset = 0;
> + u32 usb_offset = 0x2ec;
> + u32 usb_offset2 = 0x91c;
>
> - if (cpu_is_omap446x())
> - offset = 0x04;
> + if (cpu_is_omap446x()) {
> + usb_offset = 0x2f4;
> + usb_offset2 = 0x920;
> + }
Here too you should initialized these during __init. Otherwise
we'll end up piling more and more if else cpu_is_omapxxxx for
future omaps that again might change the offsets.
Tony
More information about the linux-arm-kernel
mailing list