[PATCH 08/11] MXS: Add imx-otg driver

Lothar Waßmann LW at KARO-electronics.de
Tue Apr 24 12:13:04 EDT 2012


Hi,

Sascha Hauer writes:
> On Tue, Apr 24, 2012 at 04:48:14PM +0200, Lothar Waßmann wrote:
> > Hi,
> > 
> > Marek Vasut writes:
> > > This driver handles claiming of clocks and memory areas. These are later
> > > properly delegated to it's child devices, the USB Host (ehci-mxs) and
> > > USB Gadget (ci13xxx-mxs).
> > > 
> > > Signed-off-by: Marek Vasut <marex at denx.de>
> > > Cc: Chen Peter-B29397 <B29397 at freescale.com>
> > > Cc: Detlev Zundel <dzu at denx.de>
> > > Cc: Fabio Estevam <festevam at gmail.com>
> > > Cc: Li Frank-B20596 <B20596 at freescale.com>
> > > Cc: Lin Tony-B19295 <B19295 at freescale.com>
> > > Cc: Linux USB <linux-usb at vger.kernel.org>
> > > Cc: Sascha Hauer <s.hauer at pengutronix.de>
> > > Cc: Shawn Guo <shawn.guo at freescale.com>
> > > Cc: Shawn Guo <shawn.guo at linaro.org>
> > > Cc: Stefano Babic <sbabic at denx.de>
> > > Cc: Subodh Nijsure <snijsure at grid-net.com>
> > > Cc: Tony Lin <tony.lin at freescale.com>
> > > Cc: Wolfgang Denk <wd at denx.de>
> > > ---
> > >  drivers/usb/otg/Kconfig   |    6 +
> > >  drivers/usb/otg/Makefile  |    1 +
> > >  drivers/usb/otg/imx-otg.c |  473 +++++++++++++++++++++++++++++++++++++++++++++
> > >  3 files changed, 480 insertions(+)
> > >  create mode 100644 drivers/usb/otg/imx-otg.c
> > > 
> > > diff --git a/drivers/usb/otg/Kconfig b/drivers/usb/otg/Kconfig
> > > index 5c87db0..e7c6325 100644
> > > --- a/drivers/usb/otg/Kconfig
> > > +++ b/drivers/usb/otg/Kconfig
> > > @@ -116,6 +116,12 @@ config FSL_USB2_OTG
> > >  	help
> > >  	  Enable this to support Freescale USB OTG transceiver.
> > >  
> > > +config USB_IMX_COMPOSITE
> > > +	bool
> > > +	help
> > > +	  Composite driver that handles clock and memory mapping for
> > > +	  i.MX USB host and USB PHY.
> > > +
> > >  config USB_MV_OTG
> > >  	tristate "Marvell USB OTG support"
> > >  	depends on USB_EHCI_MV && USB_MV_UDC && USB_SUSPEND
> > > diff --git a/drivers/usb/otg/Makefile b/drivers/usb/otg/Makefile
> > > index 41aa509..7d2c631 100644
> > > --- a/drivers/usb/otg/Makefile
> > > +++ b/drivers/usb/otg/Makefile
> > > @@ -20,4 +20,5 @@ obj-$(CONFIG_USB_MSM_OTG)	+= msm_otg.o
> > >  obj-$(CONFIG_AB8500_USB)	+= ab8500-usb.o
> > >  fsl_usb2_otg-objs		:= fsl_otg.o otg_fsm.o
> > >  obj-$(CONFIG_FSL_USB2_OTG)	+= fsl_usb2_otg.o
> > > +obj-$(CONFIG_USB_IMX_COMPOSITE)	+= imx-otg.o
> > >  obj-$(CONFIG_USB_MV_OTG)	+= mv_otg.o
> > > diff --git a/drivers/usb/otg/imx-otg.c b/drivers/usb/otg/imx-otg.c
> > > new file mode 100644
> > > index 0000000..8440d909
> > > --- /dev/null
> > > +++ b/drivers/usb/otg/imx-otg.c
> > > @@ -0,0 +1,473 @@
> > > +/*
> > > + * drivers/usb/otg/imx-otg.c
> > > + *
> > > + * Freescale i.MX USB composite driver.
> > > + *
> > > + * Copyright (C) 2012 Marek Vasut <marex at denx.de>
> > > + * on behalf of DENX Software Engineering GmbH
> > > + *
> > > + * This program is free software; you can redistribute it and/or modify
> > > + * it under the terms of the GNU General Public License as published by
> > > + * the Free Software Foundation; either version 2 of the License, or
> > > + * (at your option) any later version.
> > > + *
> > > + * This program is distributed in the hope that it will be useful,
> > > + * but WITHOUT ANY WARRANTY; without even the implied warranty of
> > > + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
> > > + * GNU General Public License for more details.
> > > + *
> > > + * You should have received a copy of the GNU General Public License
> > > + * along with this program; if not, write to the Free Software
> > > + * Foundation, Inc., 675 Mass Ave, Cambridge, MA 02139, USA.
> > > + */
> > > +
> > Why do you call this driver imx-otg when it is actually MXS specific?
> > How would you call a corresponding driver for the remaining i.MX
> > processors?
> 
> This is the driver for the all i.MX processors.
> 
If it is for all i.MX processors, it shouldn't access MXS specific
registers, like:
+		writel(wakeup, x->io_priv + HW_USBPHY_CTRL_SET);


Lothar Waßmann
-- 
___________________________________________________________

Ka-Ro electronics GmbH | Pascalstraße 22 | D - 52076 Aachen
Phone: +49 2408 1402-0 | Fax: +49 2408 1402-10
Geschäftsführer: Matthias Kaussen
Handelsregistereintrag: Amtsgericht Aachen, HRB 4996

www.karo-electronics.de | info at karo-electronics.de
___________________________________________________________



More information about the linux-arm-kernel mailing list