[RFC PATCH 00/10 V3] MXS: Add i.MX28 USB Host driver

[Marek Vasut]

Dear Subodh Nijsure,

> On 04/18/2012 10:46 AM, Marek Vasut wrote:
> > This patchset introduces the USB Host driver for i.MX28 CPU, utilising
> > the generic USB PHY infrastructure.
> > 
> > V2: Introduce stub imx-usb driver that then registers the PHY and EHCI
> > drivers. V3: Add the HCD on demand based on the PHY's state (only add
> > HCD if it's host).
> > 
> >      Currently, only the HOST mode is supported.
> > 
> > Marek Vasut (10):
> >    MXS: Make clk_disable return integer
> >    MXS: Add USB EHCI and USB PHY clock handling
> >    MXS: Fixup i.MX233 USB base address name
> >    MXS: Add data shared between imx-usb and EHCI driver
> >    MXS: Add platform registration hooks for USB EHCI
> >    MXS: Add imx-usb driver
> >    MXS: Add USB PHY driver
> >    MXS: Add separate MXS EHCI HCD driver
> >    MXS: Enable USB on M28EVK
> >    MXS: Enable USB on MX28EVK
> >   
> >   arch/arm/mach-mxs/Kconfig                       |    4 +
> >   arch/arm/mach-mxs/clock-mx28.c                  |   28 ++-
> >   arch/arm/mach-mxs/devices-mx28.h                |    4 +
> >   arch/arm/mach-mxs/devices/Kconfig               |    3 +
> >   arch/arm/mach-mxs/devices/Makefile              |    1 +
> >   arch/arm/mach-mxs/devices/platform-usb.c        |   78 ++++++
> >   arch/arm/mach-mxs/include/mach/clock.h          |    2 +-
> >   arch/arm/mach-mxs/include/mach/devices-common.h |    9 +
> >   arch/arm/mach-mxs/include/mach/mx23.h           |    8 +-
> >   arch/arm/mach-mxs/mach-m28evk.c                 |   15 ++
> >   arch/arm/mach-mxs/mach-mx28evk.c                |   10 +
> >   drivers/usb/host/Kconfig                        |    7 +
> >   drivers/usb/host/ehci-hcd.c                     |    5 +
> >   drivers/usb/host/ehci-mxs.c                     |  228
> >   +++++++++++++++++ drivers/usb/otg/Kconfig                         |  
> >   16 ++
> >   drivers/usb/otg/Makefile                        |    2 +
> >   drivers/usb/otg/imx-usb.c                       |  226
> >   +++++++++++++++++ drivers/usb/otg/mxs-phy.c                       | 
> >   305 +++++++++++++++++++++++ include/linux/fsl_devices.h               
> >        |   10 +
> >   19 files changed, 952 insertions(+), 9 deletions(-)
> >   create mode 100644 arch/arm/mach-mxs/devices/platform-usb.c
> >   create mode 100644 drivers/usb/host/ehci-mxs.c
> >   create mode 100644 drivers/usb/otg/imx-usb.c
> >   create mode 100644 drivers/usb/otg/mxs-phy.c
> > 
> > Cc: Chen Peter-B29397<B29397 at freescale.com>
> > Cc: Detlev Zundel<dzu at denx.de>
> > Cc: Fabio Estevam<festevam at gmail.com>
> > Cc: Li Frank-B20596<B20596 at freescale.com>
> > Cc: Lin Tony-B19295<B19295 at freescale.com>
> > Cc: Linux USB<linux-usb at vger.kernel.org>
> > Cc: Sascha Hauer<s.hauer at pengutronix.de>
> > Cc: Shawn Guo<shawn.guo at freescale.com>
> > Cc: Shawn Guo<shawn.guo at linaro.org>
> > Cc: Stefano Babic<sbabic at denx.de>
> > Cc: Subodh Nijsure<snijsure at grid-net.com>
> > Cc: Tony Lin<tony.lin at freescale.com>
> > Cc: Wolfgang Denk<wd at denx.de>
> 
> Tested this (v3) patch set on a MX28 based hardware that I have access
> to, and things worked as expected.
> 
> Tested-by:  Subodh Nijsure <snijsure at grid-net.com>

Thank you for your testing. Today, I was enlightened by some USB celestial being 
I guess ...  I finally got the UDC working and I see the whole big picture of 
how to implement this thing altogether :-) Expect V4 with some reworks, esp. 
about IRQ handling etc.

> 
> -Subodh

Best regards,
Marek Vasut