[PATCH 0/9] Add support for SPEAr13xx SoCs

Arnd Bergmann arnd at arndb.de
Sat Apr 21 08:24:47 EDT 2012


On Saturday 21 April 2012, viresh kumar wrote:
> On 4/20/12, Arnd Bergmann <arnd at arndb.de> wrote:
> > I've looked at all the platform specific bits and they look pretty good,
> > great work! I have ignored the pinctrl and clock drivers and hope that the
> > respective maintainers will be able to judge them well.
> >
> > There are a few places where you still hardcode stuff that could be turned
> > into device tree properties, but those are corner cases and you have an
> > existing platform here that you've done a great amount of excellent cleanups
> > to in the last weeks, so my feeling is that all the platform code can go in
> > when you take care of the stuff that I've commented on, most of those things
> > should be simple.
> 
> Have fixed most of stuff you pointed to. Check V2.
> 

Wow, that was fast ;-)

Can you comment on the ones you did not address? In particular,
I'd like to understand why you put the SPEAR1310_RAS_CTRL*
register definitions into a globally visible header file.

	Arnd



More information about the linux-arm-kernel mailing list