[PATCH] tty: omap-serial: Keep the wakeup mechanism enabled by default

Raja, Govindraj govindraj.raja at ti.com
Thu Apr 19 10:30:12 EDT 2012


On Thu, Apr 19, 2012 at 12:38 AM, Alan Cox <alan at lxorguk.ukuu.org.uk> wrote:
>> The point is that wakeups should be enabled whenever driver is in use,
>> and disabled when the driver is not in use.
>
>
> Which is the tty_port methods for initialisation and shutdown, which are
> mutex protected against each other and hang up.
>
> Not sure how the uart layer glue exposes that.

Is it okay to read the port flags to identify the port state in
driver whether the serial port shutdown ops is called from
port_suspend or due to port closure.

Since port_shutdown gets called even from uart_suspend_port

Is things like

test_bit(ASYNCB_SUSPENDED, &port->flags);
or
test_bit(ASYNCB_CLOSING, &port->flags);

allowed in low level driver ?

--
Thanks,
Govindraj.R



More information about the linux-arm-kernel mailing list