[PATCH 34/40] ARM: imx6: implement clocks using common clock framework

Shawn Guo shawn.guo at linaro.org
Thu Apr 19 09:56:32 EDT 2012


On Wed, Apr 18, 2012 at 01:33:55PM +0200, Sascha Hauer wrote:
> Hi Shawn,
> 
> > +
> > +static const char * const clks_init_on[] __initconst = {
> > +	"mmdc_ch0_axi", "mmdc_ch1_axi", "uart_ipg", "uart_serial",
> > +};
> 
> I assume uart_ipg and uart_serial is here for the earlyprintk case. This
> is not needed anymore. earlyprintk depends on an enabled uart anyway, so
> we can safely assume that the clock is turned on when Linux starts. The
> clock framework will disable the clock in a late initcall, long after
> the real driver has taken over and enabled the clock.
> 
Yes, that's the case for the last 2 clocks, but the first 2 clocks are
for memory and need to be kept there.  Also, currently I do not have
uart_ipg in the clkdev for uart driver to look up, so if we remove it
from clks_init_on, we need to add it into clkdev.

-- 
Regards,
Shawn



More information about the linux-arm-kernel mailing list