[PATCH 8/8] ARM: omap_hsmmc: remove platform data dma_mask and initialization
tony at atomide.com
Wed Apr 18 14:19:18 EDT 2012
* T Krishnamoorthy, Balaji <balajitk at ti.com> [120418 08:39]:
> On Wed, Apr 18, 2012 at 8:59 PM, Russell King - ARM Linux
> <linux at arm.linux.org.uk> wrote:
> > On Wed, Apr 18, 2012 at 08:53:32PM +0530, T Krishnamoorthy, Balaji wrote:
> >> Hi,
> >> drivers/mmc/host/omap.c is also using dma_mask should that also be removed
> > Does this driver make use of this platform data?
> > If so, it needs converting to DMA engine _before_ this patch (which is
> > one reason why its a good idea to do these changes as separate patches...
> > as I've done.) It means stuff like this can be slotted in as necessary
> > in the patch order.
Can't we can just do this in drivers/mmc/host/omap.c:
- host->dev->dma_mask = &pdata->dma_mask;
+ host->dev->dma_mask = 0xffffffff;
And that way drop it from the platform data. Looks like some omap1
omap_mmc_platform_data don't have it set though, but we do have host->use_dma = 1
set anyways in drivers/mmc/host/omap.c.
More information about the linux-arm-kernel