[PATCH] tty: omap-serial: Keep the wakeup mechanism enabled by default
govindraj.raja at ti.com
Wed Apr 18 09:16:31 EDT 2012
On Wed, Apr 18, 2012 at 4:55 AM, Kevin Hilman <khilman at ti.com> wrote:
> "Govindraj.R" <govindraj.raja at ti.com> writes:
>> From: "Govindraj.R" <govindraj.raja at ti.com>
>> The wakeups can be left enabled by default and should be disabled
>> only when disabled from sysfs and while entering suspend.
> Left enabled? That assumes something else has initizlied them, but we
> can't make that assumption.
> First, wakeups should be disabled when ->probe has finished. Then,
> they should be enabled whenever driver is in use, and disabled when
> the driver is not in use.
> I'm not familiar enough with uart_ops, but it looks like they should
> probably be enabled in uart_ops->startup and disabled in
uart_ops->shutdown gets called in suspend path also
serial_omap_suspend => uart_suspend_port = > ops->shutdown(uport);
This will leave uart wakeup disabled in suspend path.
More information about the linux-arm-kernel