[RFC PATCH 0/8] MXS: Add i.MX28 USB Host driver

[Chen Peter-B29397]

> >
> > On 17.04.2012 12:15, Marek Vasut wrote:
> > > This patchset introduces the USB Host driver for i.MX28 CPU,
> utilising
> > > the generic USB PHY infrastructure.
> >
> > Great, many thanks!
> 
> Hey, this is still RFC and will need a great discussion.
> 
> >
> > Unfortunately, I lost the overview over the i.MXxx USB discussion ;)
> 
> Well I put parts together from the old patchset, did some coding on my
> own ... I
> still have a few places where I'm very uncertain about so please, review
> thoroughly.
> 
> >
> > Could this be used to add support for the mx53 and mx6, too? If yes,
> > what do you think would be needed for this?
> 
> Yes, that's the plan actually. But, isn't mx53 supported by ehci-mxc? I
> thought
> the USB PHY core from mx28 was then reused only in mx6q.
> 
mx53 is still not supported by ehci-mxc.
Yes, the mx28 and mx6q use the same PHY.

> You'd have to add support for some clock handling probably (enabling the
> USB
> clock on mx53 and maybe some other clock, I'm not quite sure now without
> the
> manual), but that should be about it. The MX6q PHY on the other hand
> looks quite
> similar to mx28 so it should be easy hacking.
> 
> >
> > Best regards
> >
> > Dirk
> >
> > P.S.: What I read from the discussion:
> >
> > -- cut --
> > All recent Freescale SoC's USB controller are the same, they are mx23,
> > mx25, mx28, mx31, mx35, mx37, mx50, mx51, mx53, and mx6. But, the
> > transceiver is different between them
> > * mx23, mx28, mx6 (Transceiver A)
> > * mx25 mx31, mx35,mx37, mx50, mx51, mx53 (Transceiver B)
> > -- cut --
> >
> > > Marek Vasut (8):
> > >   MXS: Make clk_disable return integer
> > >   MXS: Add USB EHCI and USB PHY clock handling
> > >   MXS: Fixup i.MX233 USB base address name
> > >   MXS: Add platform registration hooks for USB EHCI
> > >   MXS: Add USB PHY driver
> > >   MXS: Add separate MXS EHCI HCD driver
> > >   MXS: Enable USB on M28EVK
> > >   MXS: Enable USB on MX28EVK
> > >
> > >  arch/arm/mach-mxs/Kconfig                       |    4 +
> > >  arch/arm/mach-mxs/clock-mx28.c                  |   28 +-
> > >  arch/arm/mach-mxs/devices-mx28.h                |    4 +
> > >  arch/arm/mach-mxs/devices/Kconfig               |    3 +
> > >  arch/arm/mach-mxs/devices/Makefile              |    1 +
> > >  arch/arm/mach-mxs/devices/platform-usb.c        |   79 ++++++
> > >  arch/arm/mach-mxs/include/mach/clock.h          |    2 +-
> > >  arch/arm/mach-mxs/include/mach/devices-common.h |    9 +
> > >  arch/arm/mach-mxs/include/mach/mx23.h           |    8 +-
> > >  arch/arm/mach-mxs/mach-m28evk.c                 |   10 +
> > >  arch/arm/mach-mxs/mach-mx28evk.c                |   10 +
> > >  drivers/usb/host/Kconfig                        |    7 +
> > >  drivers/usb/host/ehci-hcd.c                     |    5 +
> > >  drivers/usb/host/ehci-mxs.c                     |  309
> > >  +++++++++++++++++++++++ drivers/usb/otg/Kconfig
> > >  |    9 +
> > >  drivers/usb/otg/Makefile                        |    1 +
> > >  drivers/usb/otg/mxs-phy.c                       |  256
> > >  +++++++++++++++++++ 17 files changed, 736 insertions(+), 9
> deletions(-)
> > >  create mode 100644 arch/arm/mach-mxs/devices/platform-usb.c
> > >  create mode 100644 drivers/usb/host/ehci-mxs.c
> > >  create mode 100644 drivers/usb/otg/mxs-phy.c
> > >
> > > Cc: Chen Peter-B29397 <B29397 at freescale.com>
> > > Cc: Detlev Zundel <dzu at denx.de>
> > > Cc: Fabio Estevam <festevam at gmail.com>
> > > Cc: Li Frank-B20596 <B20596 at freescale.com>
> > > Cc: Lin Tony-B19295 <B19295 at freescale.com>
> > > Cc: Linux USB <linux-usb at vger.kernel.org>
> > > Cc: Sascha Hauer <s.hauer at pengutronix.de>
> > > Cc: Shawn Guo <shawn.guo at freescale.com>
> > > Cc: Shawn Guo <shawn.guo at linaro.org>
> > > Cc: Stefano Babic <sbabic at denx.de>
> > > Cc: Subodh Nijsure <snijsure at grid-net.com>
> > > Cc: Tony Lin <tony.lin at freescale.com>
> > > Cc: Wolfgang Denk <wd at denx.de>
> 
> Best regards,
> Marek Vasut