[PATCH 7/8] MXS: Enable USB on M28EVK

[Sergei Shtylyov]

Hello.

On 04/17/2012 02:15 PM, Marek Vasut wrote:

> Enable the second USB port on M28EVK board.

> Signed-off-by: Marek Vasut<marex at denx.de>
> Cc: Chen Peter-B29397<B29397 at freescale.com>
> Cc: Detlev Zundel<dzu at denx.de>
> Cc: Fabio Estevam<festevam at gmail.com>
> Cc: Li Frank-B20596<B20596 at freescale.com>
> Cc: Lin Tony-B19295<B19295 at freescale.com>
> Cc: Linux USB<linux-usb at vger.kernel.org>
> Cc: Sascha Hauer<s.hauer at pengutronix.de>
> Cc: Shawn Guo<shawn.guo at freescale.com>
> Cc: Shawn Guo<shawn.guo at linaro.org>
> Cc: Stefano Babic<sbabic at denx.de>
> Cc: Subodh Nijsure<snijsure at grid-net.com>
> Cc: Tony Lin<tony.lin at freescale.com>
> Cc: Wolfgang Denk<wd at denx.de>
[...]

> @@ -377,6 +382,11 @@ static void __init m28evk_init(void)
>   	mx28_add_ts(&touch_pdata);
>
>   	mx28_add_gpmi_nand(&m28evk_gpmi_nand_data);
> +
> +	gpio_request(MXS_GPIO_NR(3, 13), "USB");

    gpio_request() can fail and you don't handle it.

> +	gpio_direction_output(MXS_GPIO_NR(3, 13), 0);

    You can use gpio_request_one() instead of the above 2 calls.

WBR, Sergei