[PATCH v3 6/6] ARM: vexpress: plug local timers into the DT code

Marc Zyngier marc.zyngier at arm.com
Tue Apr 17 05:41:52 EDT 2012


On 17/04/12 10:22, Pawel Moll wrote:
> On Mon, 2012-04-16 at 17:13 +0100, Marc Zyngier wrote:
>> @@ -643,6 +644,11 @@ static void __init v2m_dt_timer_init(void)
>>  		return;
>>  	node = of_find_node_by_path(path);
>>  	v2m_sp804_init(of_iomap(node, 0), irq_of_parse_and_map(node, 0));
>> +	if (arch_timer_of_register())
>> +		twd_local_timer_of_register();
>> +
>> +	if (arch_timer_sched_clock_init())
>> +		versatile_sched_clock_init(v2m_sysreg_base + V2M_SYS_24MHZ, 24000000);
>>  }
> 
> My personal preference would be "if (arch_timer*() != 0)" here -
> obviously makes no difference, but clearly states the idea, but anyway
> looks good to me.

Fair enough.

> Acked-by: Pawel Moll <pawel.moll at arm.com>

Thanks Paweł.

	M.
-- 
Jazz is not dead. It just smells funny...




More information about the linux-arm-kernel mailing list