[PATCH] CLKDEV: Add helper routines to allocate and add clkdevs for given struct clk *

s.hauer at pengutronix.de s.hauer at pengutronix.de
Mon Apr 16 17:12:32 EDT 2012


On Mon, Apr 16, 2012 at 11:06:18PM +0200, Domenico Andreoli wrote:
> > >  - allocate and add single clkdev for a single clk structure.
> > >  - add multiple clkdevs for a single clk structure.
> > > 
> > > +
> > > +int clk_register_single_clkdev(struct clk *clk, const char *con_id,
> > > +		const char *dev_fmt, ...)
> > 
> > Can we drop the 'single' in the name? Otherwise it's quite a long
> > function name. I think name clk_register_clkdev makes it clear already
> > that we only register a single clkdev.
> 
> clkdev_register?

Maybe even this. I just though that it might be too easy to confuse with
clkdev_add (In fact I think clkdev_register would be a good name for
what clkdev_add currently does, but it's probably not worth the churn
changing this).

Sascha


-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |



More information about the linux-arm-kernel mailing list