[PATCH V4 1/5] of: Implement managed of_iomap()

Grant Likely grant.likely at secretlab.ca
Mon Apr 16 11:06:56 EDT 2012


On Mon, Apr 16, 2012 at 8:42 AM, Arnd Bergmann <arnd at arndb.de> wrote:
> On Monday 16 April 2012, Viresh Kumar wrote:
>> This simplifies cleanup paths of user code by providing managed version of
>> of_iomap().
>>
>> Signed-off-by: Viresh Kumar <viresh.kumar at st.com>
>> Cc: Grant Likely <grant.likely at secretlab.ca>
>
>
> This one looks good,
>
> Acked-by: Arnd Bergmann <arnd at arndb.de>
>
> but I wonder if we should also have a devm_of_request_and_ioremap
> (maybe with a shorter name) that combines this with request_resource.

Why is this function needed?  I'm directing drivers away from using
of_iomap now since the resource table is populated with the address
ranges at device registration time now.  New code should be using
platform_get_resource() if it is a platform device.

g.



More information about the linux-arm-kernel mailing list