[PATCH] CLKDEV: Add helper routines to allocate and add clkdevs for given struct clk *
Viresh Kumar
viresh.kumar at st.com
Mon Apr 16 06:39:25 EDT 2012
On 4/16/2012 4:08 PM, Russell King - ARM Linux wrote:
> I don't think these checks actually help anyone, especially if the user
> forgets to check the return value (which makes them silent errors.)
>
> If you're going to abuse the interface by passing a NULL clk_lookup or
> num=0 then you deserve to get a big fat oops to tell you that you messed
> up. Same for NULL dev_id and con_id above.
>
> Checking for NULL clk (or IS_ERR(clk)) and returning -ENOMEM does make
> sense as I mentioned in my original proposal (it allows you to pass the
> returned value from clk_register() directly to this function without
> further checking, and you get the right error code.
Got it.
--
viresh
More information about the linux-arm-kernel
mailing list