[PATCH 25/40] ARM: imx: add common clock support for clk busy
Shawn Guo
shawn.guo at linaro.org
Wed Apr 11 22:44:18 EDT 2012
On Thu, Apr 12, 2012 at 09:50:14AM +0800, Richard Zhao wrote:
...
> > +struct clk_busy_divider {
> > + struct clk_hw hw;
> > + void __iomem *reg;
> > + u8 shift;
> > + struct clk_divider div;
> > + const struct clk_ops *div_ops;
> > +};
> It's not like a good way to inherit from struct clk_divider.
Any good way to suggest?
> Since we
> already have struct clk_hw in struct clk_divider, why do you still
> duplicate hw here?
>
I can use the clk_hw in clk_divider, but it will make the translation
from clk_hw to clk_busy_divider a bit more complicated. And in any
case, clk_busy_divider is a particular type of clk, so it should not
be surprising to have a its own clk_hw like any other clks.
--
Regards,
Shawn
More information about the linux-arm-kernel
mailing list