[PATCH 2/2] dma/amba-pl08x: add support for the Nomadik variant

Viresh Kumar viresh.kumar at st.com
Wed Apr 11 03:59:56 EDT 2012


On 4/11/2012 1:29 PM, Linus Walleij wrote:
>>> >> +                             ch->locked = true;
>>> >> +                     } else
>>> >> +                             ch->locked = false;
>>> >> +             }
>>> >> +
>> >
>> > Memory for ch is allocated with kmalloc and so its default value is garbage.
>> > So we must set locked to false in else part here.
> Hm maybe better to kzalloc() the channel structs?
> 

Then, you can remove code which makes its field zero explicitly, as it is already
zero.

-- 
viresh



More information about the linux-arm-kernel mailing list