[PATCHv2] ARM: orion5x: Fix GPIO enable bits for MPP9

Jason Cooper jason at lakedaemon.net
Tue Apr 10 21:29:56 EDT 2012


On Sun, Apr 08, 2012 at 05:18:53AM +0100, Ben Hutchings wrote:
> Commit 554cdaefd1cf7bb54b209c4e68c7cec87ce442a9 ('ARM: orion5x: Refactor
> mpp code to use common orion platform mpp.') seems to have accidentally
> inverted the GPIO valid bits for MPP9 (only).  For the mv2120 platform
> which uses MPP9 as a GPIO LED device, this results in the error:
> 
> [   12.711476] leds-gpio: probe of leds-gpio failed with error -22
> 
> Reported-by: Henry von Tresckow <hvontres at gmail.com>
> References: http://bugs.debian.org/667446
> Signed-off-by: Ben Hutchings <ben at decadent.org.uk>
> Cc: stable at vger.kernel.org [v3.0+]
> ---
> v2: Add subject of the earlier commit

oops, replied to the earlier one before seeing this one.  Playing
catchup after the holidays.

Please see my earlier post regarding possible breakage on other boards.

thx,

Jason.

>  arch/arm/mach-orion5x/mpp.h |    4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/arch/arm/mach-orion5x/mpp.h b/arch/arm/mach-orion5x/mpp.h
> index eac6897..db70e79 100644
> --- a/arch/arm/mach-orion5x/mpp.h
> +++ b/arch/arm/mach-orion5x/mpp.h
> @@ -65,8 +65,8 @@
>  #define MPP8_GIGE               MPP(8,  0x1, 0, 0, 1,   1,   1)
>  
>  #define MPP9_UNUSED		MPP(9,  0x0, 0, 0, 1,   1,   1)
> -#define MPP9_GPIO		MPP(9,  0x0, 0, 0, 1,   1,   1)
> -#define MPP9_GIGE               MPP(9,  0x1, 1, 1, 1,   1,   1)
> +#define MPP9_GPIO		MPP(9,  0x0, 1, 1, 1,   1,   1)
> +#define MPP9_GIGE               MPP(9,  0x1, 0, 0, 1,   1,   1)
>  
>  #define MPP10_UNUSED		MPP(10, 0x0, 0, 0, 1,   1,   1)
>  #define MPP10_GPIO		MPP(10, 0x0, 1, 1, 1,   1,   1)
> -- 
> 1.7.9.5
> 
> 
> 
> 
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel at lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel



More information about the linux-arm-kernel mailing list