[PATCH V3 1/5] ARM: kirkwood: Basic support for DNS-320 and DNS-325

Mon Apr 9 17:27:48 EDT 2012

On Fri, Apr 06, 2012 at 04:49:55PM -0700, Grant Likely wrote:
> On Tue, 27 Mar 2012 22:54:11 +0100, Jamie Lentin <jm at lentin.co.uk> wrote:
> > +config MACH_DNS320_DT
> > +	bool "D-Link DNS-320 (Flattened Device Tree)"
> > +	select ARCH_KIRKWOOD_DT
> > +	select MACH_DNSKW_DT
> > +	select CONFIG_MTD_OF_PARTS
> > +	select CONFIG_SERIAL_OF_PLATFORM
> 
> These two lines are dangerous.

No they aren't - at least not as the above patch is written.  There are
no configuration variables called CONFIG_CONFIG_MTD_OF_PARTS nor
CONFIG_CONFIG_SERIAL_OF_PLATFORM.

Kconfig won't warn about that, and if we assume that this patch has been
properly tested, it would appear that these two select statements just
aren't required (because they're effective no-ops as they currently stand).