[PATCH V3 1/5] ARM: kirkwood: Basic support for DNS-320 and DNS-325

Grant Likely grant.likely at secretlab.ca
Fri Apr 6 19:43:13 EDT 2012


On Wed, 28 Mar 2012 08:19:59 +0000, Arnd Bergmann <arnd at arndb.de> wrote:
> On Tuesday 27 March 2012, Jamie Lentin wrote:
> > Add support for the DNS-320 and DNS-325. Describe as much as currently possible
> > in the devicetree files, create a board-dnskw.c for everything else.
> > 
> > Use IEEE-compliant "okay", rather than "ok"
> > 
> > Acked-by: Arnd Bergmann <arnd at arndb.de>
> > Acked-by: Jason Cooper <jason at lakedaemon.net>
> > Signed-off-by: Jamie Lentin <jm at lentin.co.uk>
> > ---
> 
> One small note about changeset comments: The part about differences from the previous
> version of the same patch normally goes below the '---' line, in front of the diffstat,
> to prevent it from going into the git changelog. Otherwise people will have no idea
> what it's about.

Counter point on that.  I ask submitters to put the changelog before
the --- because I want it in the commit text.  It is actually helpful
when trying to determine exactly which iteration of a patch series got
committed.

But, different maintainers have different policies so there really
isn't much submitters can do here except ask the maintainer they are
submitting to which approach they prefer.

g.

-- 
Grant Likely, B.Sc, P.Eng.
Secret Lab Technologies,Ltd.



More information about the linux-arm-kernel mailing list