[RESEND PATCH] ARM :OMAP2+: UART: Remove some of uart default pads

Tony Lindgren tony at atomide.com
Fri Apr 6 14:15:57 EDT 2012


* Raja, Govindraj <govindraj.raja at ti.com> [120405 23:08]:
> On Thu, Apr 5, 2012 at 10:28 PM, Tony Lindgren <tony at atomide.com> wrote:
> >
> > Hmm I don't think any muxing was done automatically unless
> > omap_serial_init_port was being called with pins.
> 
> Muxing was happening even if we don't call omap_serial_init_port
> rx pin was muxed for wakeup capability for all uart pins

OK, but that was only for the wake-up muxing? That sounds risky
too for some boards as the board may be using alternative uart
pins instead of the default ones.
 
> omap_uart_idle_init => was populating padconf offset value for ech uart
> which was used in omap_uart_enable/disable_wakeup functions.
> This mechanism was keeping PM happening for all boards.

OK, that's safe if we also bail out for the cases where the default
uart pins are not muxed to serial functionality to start with.

So to summarize, the right fix is to:

1. Only do muxing of uarts from other modes to uart mode if
   omap_serial_init_port is being called with the board specific
   mux options for the port in question.

2. Bail out early in omap_serial_init for each port that does not
   have it's default uart pins already muxed to uart functionality.

3. For the uart ports configured in #1 or #2 above, allow dynamic
   remuxing of the wake-up capability but don't touch the others.

Regards,

Tony



More information about the linux-arm-kernel mailing list