[PATCH] ARM: kirkwood: add missing kexec.h include

Sergei Shtylyov sshtylyov at mvista.com
Fri Apr 6 13:45:06 EDT 2012


On 04/06/2012 05:10 PM, Ian Campbell wrote:

>>> Fixes build the following error when CONFIG_KEXEC is enabled:

>>      Maybe "the following build error" instead?

> Done.

   Not quite. Still "fixes build the following...". :-)

>>>     CC      arch/arm/mach-kirkwood/board-dt.o
>>> arch/arm/mach-kirkwood/board-dt.c: In function 'kirkwood_dt_init':
>>> arch/arm/mach-kirkwood/board-dt.c:52:2: error: 'kexec_reinit' undeclared (first use in this function)
>>> arch/arm/mach-kirkwood/board-dt.c:52:2: note: each undeclared identifier is reported only once for each function it appears in

>>> kexec.h also needs string.h.

>>      Why it doesn't include it?

> Not sure, but actually I should be using linux/kexec.h not asm/kexec.h
> anyway which solves the problem too:

> 8<------------------------------

>  From 76ef56286c1ceeceaa4c6c5ba867d9504e175382 Mon Sep 17 00:00:00 2001
> From: Ian Campbell<ijc at hellion.org.uk>
> Date: Fri, 6 Apr 2012 13:27:23 +0100
> Subject: [PATCH] ARM: kirkwood: add missing kexec.h include

> Fixes build the following build error when CONFIG_KEXEC is enabled:

    What I meant was "Fixes the following build error when CONFIG_KEXEC is 
enabled:".

>    CC      arch/arm/mach-kirkwood/board-dt.o
> arch/arm/mach-kirkwood/board-dt.c: In function 'kirkwood_dt_init':
> arch/arm/mach-kirkwood/board-dt.c:52:2: error: 'kexec_reinit' undeclared (first use in this function)
> arch/arm/mach-kirkwood/board-dt.c:52:2: note: each undeclared identifier is reported only once for each function it appears in

> Signed-off-by: Ian Campbell<ijc at hellion.org.uk>
> [v2, using linux/kexec.h not asm/kexec.h]

WBR, Sergei



More information about the linux-arm-kernel mailing list