Using GPMI-NAND driver on iMX28 using 3.4-rc1?
Shawn Guo
shawn.guo at linaro.org
Fri Apr 6 10:21:53 EDT 2012
On Fri, Apr 06, 2012 at 07:06:41AM -0700, Sam Gandhi wrote:
...
> Well then change the name of the function
> mxs_assign_cookie_enable_chan(), my point still stands.
>
I just do not see the need of such churn.
> As the case illustrates cookie needs to assigned before enabling the
> channel then why not do it in that function itself.
It's simply because cookie is cookie and channel is channel.
> At worst please
> put a comment in mxs_assign_cookie_enable() that says cookie must be
> assigned prior to calling enable channel.
>
It's the best rather than worst to me.
--
Regards,
Shawn
More information about the linux-arm-kernel
mailing list