[PATCH v8 4/4] ARM: mxs/mx28evk: add GPMI-NAND device
shawn.guo at linaro.org
Fri Apr 6 02:53:05 EDT 2012
On Fri, Apr 06, 2012 at 02:49:05AM -0300, Fabio Estevam wrote:
> On Thu, Apr 5, 2012 at 11:31 PM, Shawn Guo <shawn.guo at linaro.org> wrote:
> > I have to do that to motivate people to add DT support for the drivers
> > they submit from the beginning.
> Understand your point for new drivers.
> If you take the GPMI driver for example: it has been available for a
> long time and there is no board using it in mainline.
> So how can people easily test it and find bugs with this driver?
> Patching their own trees themselves? Sam Gandhi did extensive tests on
> NAND and found some DMA issues with it.
Look, people can still test and find issue with no board in mainline
> If we could have mx28evk supporting GPMI driver today it would
> estimulate people to use it and more issues can be found and fixed.
> Waiting for DT support to be in place is just blocking the progress for mx28.
Please tell me what are exactly being blocked there.
> Please note that right now there is no dt support for mx28 in mainline.
There are still no spi-mxs driver in mainline, why are you sending me
spi board file patches?
> If what blocks this patch "ARM: mxs/mx28evk: add GPMI-NAND device" to
> be accepted is the pin mux conflict, that would be easy to fix and
> Huang could do a v5 if you agree.
We had the discussion and agreed that migrating to pinctrl subsystem is
the right solution. I will be more than happy to accept if someone
send me mxs pinctrl support rather than any "easy" fix.
> > Also I do not see much point to keep patching board files which are
> > to be removed.
> I understand your point, but again, right now there is no dt support,
> so the only mechanism we have to register driver is via board files
> for mx28.
> So it would be nice if you could still accept patches for mx28 while
> mx28 dt does not show up in mainline.
I could accept your spi board file patch when spi-mxs driver hit
mainline while mx28 dt does not.
More information about the linux-arm-kernel