[PATCH v7 09/11] ARM: pxa: change gpio to platform device

Chris Ball cjb at laptop.org
Fri Apr 6 00:49:22 EDT 2012

Hi Haojian,

On Fri, Apr 06 2012, Chris Ball wrote:
> On Tue, Nov 08 2011, Haojian Zhuang wrote:
>> Remove most gpio macros and change gpio driver to platform driver.
>> Signed-off-by: Haojian Zhuang <haojian.zhuang at marvell.com>
> Please could you help me understand how this patch (which was merged
> in 3.2) relates to mach-mmp's use of gpio-pxa?  The patch changes
> pxa_gpio_probe() to check for gpio0/gpio1/gpio_mux in platform data:
> [..]
> But the patch only adds these resources to arch/arm/mach-pxa/devices.c:
> [..]
> and not anywhere under arch/arm/mach-mmp, which means that when we look
> for these names on a mach-mmp device (in my case, OLPC XO-1.75/MMP2),
> we hit the "return -EINVAL" above due to the missing platform resources.
> Using gpio-pxa on mach-mmp devices worked fine on kernels before 3.2.

Ah, I eventually found your "ARM: mmp: append irq name of gpio device"
patch, which was merged in 3.4-rc1 and fixes gpio-pxa on mach-mmp.
I think this patch should go to stable@, since the regression is
still unfixed in 3.2 and 3.3.


- Chris.
Chris Ball   <cjb at laptop.org>   <http://printf.net/>
One Laptop Per Child

More information about the linux-arm-kernel mailing list