[PATCH] ARM: OMAP2+: PRM: fix compile for OMAP4-only build

Kevin Hilman khilman at ti.com
Thu Apr 5 20:07:31 EDT 2012


Paul Walmsley <paul at pwsan.com> writes:

> On Thu, 5 Apr 2012, Kevin Hilman wrote:
>
>> For OMAP4 only builds, the omap2_prm_* functions have dummy wrappers
>> to detect incorrect usage.  However, several unrelated omap3 PRM
>> functions have made it inside the #else clause of the #ifdef wrapping
>> the omap2_prm stubs, causing them to disappear on OMAP4-only builds.
>> 
>> This was unnoticed until the IO chain support was added and introduced
>> a new function in this section which is referenced by omap_hwmod.c:
>> 
>> /work/kernel/omap/dev/arch/arm/mach-omap2/omap_hwmod.c: In function '_reconfigure_io_chain':
>> /work/kernel/omap/dev/arch/arm/mach-omap2/omap_hwmod.c:1665:3: error: implicit declaration of function 'omap3xxx_prm_reconfigure_io_chain' [-Werror=implicit-fungiction-declaration]
>> 
>> Fix by using the #ifdef to only wrap the omap2_prm functions that
>> need stubs on OMAP4-only builds.
>> 
>> Cc: Paul Walmsley <paul at pwsan.com>
>> Signed-off-by: Kevin Hilman <khilman at ti.com>
>> ---
>> Paul, this patch applies on top your io_chain_devel_3.5 branch.
>
> Thanks, Tony reported this too.  Any objections to me rolling this into 
> the offending patch?

No objections.

Kevin



More information about the linux-arm-kernel mailing list