[PATCH] serial: PL011: move interrupt clearing

Greg Kroah-Hartman gregkh at linuxfoundation.org
Tue Apr 3 12:19:23 EDT 2012


On Tue, Apr 03, 2012 at 11:36:23AM -0400, Paul Gortmaker wrote:
> On Thu, Mar 29, 2012 at 5:33 PM, Greg Kroah-Hartman
> <gregkh at linuxfoundation.org> wrote:
> > On Thu, Mar 29, 2012 at 02:49:37PM -0600, Grant Likely wrote:
> >> On Wed, Mar 21, 2012 at 1:15 PM, Linus Walleij <linus.walleij at linaro.org> wrote:
> >> > Commit 360f748b204275229f8398cb2f9f53955db1503b
> >> > "serial: PL011: clear pending interrupts"
> >> > attempts to clear interrupts by writing to a
> >> > yet-unassigned memory address. This fixes the issue.
> >> >
> >> > The breaking patch is marked for stable so should be
> >> > carried along with the other patch.
> >> >
> >> > Cc: Shreshtha Kumar Sahu <shreshthakumar.sahu at stericsson.com>
> >> > Cc: Russell King <linux at arm.linux.org.uk>
> >> > Cc: stable <stable at vger.kernel.org>
> >> > Reported-by: Viresh Kumar <viresh.kumar at st.com>
> >> > Signed-off-by: Linus Walleij <linus.walleij at linaro.org>
> >>
> >> Ugh; the original patch is obviously broken.  How did it get applied
> >> without testing?
> >>
> >> Greg, can you get this out to Linus ASAP please?  I have one comment
> >> below, but I don't think it should block merging this patch.
> >>
> >> Tested-by: Grant Likely <grant.likely at secretlab.ca>
> >
> > Thanks, I'll get it to him after 3.4-rc1 is out, in a few days, along
> > with other tty fixes being queued up.
> 
> Hi Greg,
> 
> Just wanted to check this didn't fall through the cracks, as I don't
> see it in your tty-next or tty-linus branches.
> 
> The original bad commit causes Silent Boot Death on qemu ARM
> versatile, which is kind of nasty.  It pretty much forces a bisection,
> which I did, which then led me here.

It's still in my "to-apply" queue, don't worry, it's not lost.

greg k-h



More information about the linux-arm-kernel mailing list