[PATCH] ARM: versatile: fix build failure in pci.c

Arnd Bergmann arnd at arndb.de
Tue Apr 3 10:26:22 EDT 2012


On Tuesday 03 April 2012, Paul Gortmaker wrote:
> I'm not sure I'm following you here. I'm not feeding the
> struct pci_sys_data to pci_add_resource_offset.  Instead it
> is getting subfields of it, consistent with the rest of the
> original commit from Bjorn.

Sorry, my fault, I thought the suggestion was to pass sys into
pci_add_resource_offset.

However, I would still prefer just reverting the versatile
part of Bjorn's patch because versatile uses a zero offset.
I think we should only pass the offset in cases where it's
actually required because there are multiple buses or they
have interesting mappings to the physical address space.

Those seem to be the minority on ARM anyway.

	Arnd



More information about the linux-arm-kernel mailing list