[PATCH] ARM: versatile: fix build failure in pci.c

Arnd Bergmann arnd at arndb.de
Tue Apr 3 04:19:48 EDT 2012


On Tuesday 03 April 2012, Fabio Estevam wrote:
> On Mon, Apr 2, 2012 at 10:01 PM, Paul Gortmaker
> <paul.gortmaker at windriver.com> wrote:
> 
> > I see.  Well, there weren't any follow ups to it but I would say that
> > passing both sys->resources and sys both side-by-side at the same
> > time doesn't really make sense.  I think just passing in sys by itself
> > as I did is a cleaner way to go, wouldn't you agree?
> 
> Yes, I agree.

But that doesn't work: struct pci_sys_data is ARM specific, while
pci_add_resource_offset is common code.

I think it would be much more sensible here to just use pci_add_resource(),
which is the same as the offsets are all zero for versatile.

	Arnd



More information about the linux-arm-kernel mailing list