[PATCH/RFC v2] ARM: amba: Remove AMBA level regulator support

Linus Walleij linus.walleij at linaro.org
Sun Apr 1 18:39:11 EDT 2012


On Sun, Apr 1, 2012 at 9:39 PM, Rabin Vincent <rabin at rab.in> wrote:
> On Mon, Apr 2, 2012 at 00:52, Linus Walleij <linus.walleij at linaro.org> wrote:
>> Combined with the PL022 patch this causes a power regression since
>> the PL022 is hereafter always on.
>
> How can there be a "power regression" here?  This is the only user of
> the vcore regulator, and, apart from the fact that its disable routine
> only decrements an essentialy write-only variable, it is shared which
> several devices which already never disable it.

Yes true... Hm I hope something else in mainline will increase refcount
to vape so it's not disabled at regulator_has_full_constraints()? Better
test it, then I'll see.

Mark: as Rabin says the v1 patch is probably fine, are you pushing this
to ARM SoC or into Russell's patch tracker?

Yours,
Linus Walleij



More information about the linux-arm-kernel mailing list