[PATCH] mmci: calculate remaining bytes at error correctly

Sergei Shtylyov sshtylyov at mvista.com
Mon Jan 31 07:00:12 EST 2011


Hello.

On 31-01-2011 0:28, Russell King - ARM Linux wrote:

> Linus,

> Here's another couple of fixes...

> 8<----
> Subject: [PATCH 1/2] ARM: mmci: complete the transaction on error

> When we encounter an error, make sure we complete the transaction
> otherwise we'll leave the request dangling.

> Signed-off-by: Russell King<rmk+kernel at arm.linux.org.uk>
[...]

> diff --git a/drivers/mmc/host/mmci.c b/drivers/mmc/host/mmci.c
> index b6fd6dc..175a623 100644
> --- a/drivers/mmc/host/mmci.c
> +++ b/drivers/mmc/host/mmci.c
> @@ -319,7 +319,7 @@ mmci_data_irq(struct mmci_host *host, struct mmc_data *data,
>   	if (status&  MCI_DATABLOCKEND)
>   		dev_err(mmc_dev(host->mmc), "stray MCI_DATABLOCKEND interrupt\n");
>
> -	if (status & MCI_DATAEND) {
> +	if (status & MCI_DATAEND

    Shouldn't 'status & MCI_DATAEND' be enclosed in parens?

> || data->error) {

WBR, Sergei



More information about the linux-arm-kernel mailing list