[PATCH 1/1] ARM: imx53_loco: add all pad configure.

Richard Zhao richard.zhao at freescale.com
Sat Jan 29 21:09:40 EST 2011


On Sat, Jan 29, 2011 at 03:05:50PM -0200, Fabio Estevam wrote:
> On Sat, Jan 29, 2011 at 12:11 PM, Richard Zhao <linuxzsc at gmail.com> wrote:
> > On Sat, Jan 29, 2011 at 11:31:38AM -0200, Fabio Estevam wrote:
> >> Hi Richard,
> >>
> >> On Sat, Jan 29, 2011 at 8:48 AM, Richard Zhao <linuxzsc at gmail.com> wrote:
> >> > Signed-off-by: Richard Zhao <richard.zhao at freescale.com>
> >> >
> >> > diff --git a/arch/arm/mach-mx5/board-mx53_loco.c b/arch/arm/mach-mx5/board-mx53_loco.c
> >> > index 3aefd6d..d724ac8 100644
> >> > --- a/arch/arm/mach-mx5/board-mx53_loco.c
> >> > +++ b/arch/arm/mach-mx5/board-mx53_loco.c
> >> > @@ -39,8 +39,145 @@
> >> >  #define LOCO_FEC_PHY_RST               IMX_GPIO_NR(7, 6)
> >>
> >> Don´t you also need to define the PAD_CTRL settings for the different
> >> peripherals in iomux-53.h?
> > Dinh is doing the SoC level work. I don't think I need to repeat the effort.
> 
> Then don´t you think it is better to add the board level IOMUX after
> Dinh´s work?
I don't think so. We already have Dinh's initial version of iomux-mx53.h. It can
pass build and work for current device added. 
At least we have correct mux set, we can test on that. When we summit new device
drivers, we can check the pad settings and fix it in case we don't have correct
one yet.
It's also the way we can upstream as fast as possible.

Thanks
Richard
> 
> Regards,
> 
> Fabio Estevam
> 




More information about the linux-arm-kernel mailing list