[PATCH 0/5] OMAP3EVM: Board bug fixes/enhancements

Kevin Hilman khilman at ti.com
Thu Jan 27 15:05:13 EST 2011


Hi Vaibhav,

"Hiremath, Vaibhav" <hvaibhav at ti.com> writes:

[...]

>> 
>> >   OMAP3EVM: Made backlight GPIO default state to off
>> >   OMAP3EVM: Set TSC wakeup option in pad config
>> 
>> And this one doesn't apply as it seems to apply on top of code that
>> doesn't exist upstream.
>> 
>
> You should first apply Ethernet-reset patch first, and then all
> patches will get applied cleanly. I have tested it here at my end.

OK, sorry to have missed that one.

In the future, dependencies need to be clearly stated in the patch 0
cover letter.  When reviewers/maintainers are looking at lots of
patches, it is not easy to keep context for all the patches and series
arriving on the list.  Additional information such as dependencies and
change history are extremely valuable to reviewers & maintainers.

> Since you already acked Ethernet patch, I thought it will make its way
> to mainline before all these patches. And also while posting, I posted
> Ethernet patch again first and then this series.

It will likely make it's way upstream sooner since it's a regression
fix, however, it is not yet queued anywhere so dependencies on it should
be clearly stated here.

Thanks,

Kevin




More information about the linux-arm-kernel mailing list