[PATCH v2] arm: Configure reference clock for Versatile Express timers

Russell King - ARM Linux linux at arm.linux.org.uk
Mon Jan 24 11:42:48 EST 2011


On Mon, Jan 24, 2011 at 04:38:20PM +0000, Pawel Moll wrote:
> > > I've removed them, because the sp804 driver is initializing these
> > > registers in sp804_clocksource_init() and sp804_set_mode(), just
> > > a jiffy later.
> > What if we have some other more preferable clock events which
> > rules in set_mode not being called?  How do we ensure that these
> > timers won't create some spurious interrupts?
> 
> Good point. The sp804_clockevent_init() should do this. A patch is just
> going out...

No.  Think about it.  Some platforms have four timers.  Should we leave
two uninitialized?  Should we have arch code initialize the two they're
not using, and have the clockevents/clocksource code initialize the
other two?  Or should we have the arch code take care of it all.

My approach which is done for _all_ ARM platforms is to have the arch
code do it.  If you're going to change that, change _all_ ARM platforms
and justify why it's correct to make it less clear that everything is
properly initialized in one place.



More information about the linux-arm-kernel mailing list