[PATCH] mmci: fixup broken_blockend variant patch v2
linus.ml.walleij at gmail.com
Mon Jan 24 03:18:19 EST 2011
2011/1/24 Russell King - ARM Linux <linux at arm.linux.org.uk>:
> On Sun, Jan 23, 2011 at 10:40:05PM +0100, Linus Walleij wrote:
>> 2011/1/23 Russell King - ARM Linux <linux at arm.linux.org.uk>:
>> > On Fri, Jan 21, 2011 at 01:53:06PM +0100, Linus Walleij wrote:
>> > If we're going to move away from the blockend IRQs to using the data
>> > counter, can we have a patch which switches the driver to use the data
>> > counter and then a followup patch which removes the broken blockend
>> > stuff, rather than somethign that changes the broken blockend stuff
>> > and then removes it?
>> 6631/1 fixes the broken blockend stuff into a state that works,
>> then 6632/1 removes it in favor of using the MMCIDATACNT.
> What I'm saying is why do we need to fix the blockend stuff if in the
> next patch we remove it - why not just combine the two patches and
> remove the thing in one go as a "we give up using the blockend irq"?
OK I get it, no, of course 6631 and 6632 can be squashed. I'll do
this, take out 6631 and have 6632 be the squashed result, will
be fixed in a few minutes.
More information about the linux-arm-kernel