[PATCH 1/3] Support BE8 mode kernel modules relocation
Russell King - ARM Linux
linux at arm.linux.org.uk
Sat Jan 22 12:00:44 EST 2011
On Fri, Jan 21, 2011 at 06:11:45PM +0800, stanley.miao wrote:
> Russell King - ARM Linux wrote:
>> On Wed, Jan 19, 2011 at 02:44:45PM +0800, Stanley.Miao wrote:
>>
>>> @@ -174,9 +186,9 @@ apply_relocate(Elf32_Shdr *sechdrs, const char *strtab, unsigned int symindex,
>>> * other bits to re-code instruction as
>>> * MOV PC,Rm.
>>> */
>>> - *(u32 *)loc &= 0xf000000f;
>>> - *(u32 *)loc |= 0x01a0f000;
>>> - break;
>>> + write_instr32((read_instr32(loc) & 0xf000000f) |
>>> + 0x01a0f000, loc);
>>> + break;
>>>
>>
>> Indentation error.
>>
>>
> Actually, The indentation of my code is right, and the original code is
> wrong.
Yes, you're right. Please precede your patch which a patch which _just_
corrects the formatting of the old code.
More information about the linux-arm-kernel
mailing list