[PATCH 5/6] dmaengine: imx-sdma: fix up param for the last BD in sdma_prep_slave_sg()

[Sascha Hauer]

On Fri, Jan 21, 2011 at 11:15:39PM +0800, Shawn Guo wrote:
> Hi Sascha,
> 
> On Thu, Jan 20, 2011 at 11:28:08AM +0100, Sascha Hauer wrote:
> > On Thu, Jan 20, 2011 at 05:50:39AM +0800, Shawn Guo wrote:
> > > As per the reference manual, bit "L" should be set while bit "C"
> > > should be cleared for the last buffer descriptor in the non-cyclic
> > > chain, so that sdma can stop trying to find the next BD and end
> > > the transfer.
> > > 
> > > In case of sdma_prep_slave_sg(), BD_LAST needs to be set and BD_CONT
> > > be cleared for the last BD.
> > 
> > Did you test this patch?
> > 
> Would you suggest any driver on mx51 using this api?  So that I can
> test it on my babbage board.  Or you can help test it with mx27/31
> mmc driver?  I do not have them on my end.  Thanks.

I can only suggest the imx/imx-sdma-sound-mx353ds-mx51_babbage
branch, but this only uses cyclic transfers so you can't use it
to test this patch.
I asked because I could add an ack to this patch if it has been
tested. Without testing I'd like delaying it until I found some
time testing it.

Sascha


-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |