[PATCH v2] OMAP: use fncpy to copy the PM code functions to SRAM
Tony Lindgren
tony at atomide.com
Wed Jan 19 17:10:57 EST 2011
* Kevin Hilman <khilman at ti.com> [110119 13:37]:
> Kevin Hilman <khilman at ti.com> writes:
>
> > jean.pihet at newoldbits.com writes:
> >
> >> From: Jean Pihet <j-pihet at ti.com>
> >>
> >> The new fncpy API is better suited for copying some
> >> code to SRAM at runtime. This patch changes the ad-hoc
> >> code to the more generic fncpy API.
> >>
> >> Tested OK on OMAP3 in low power modes (RET/OFF)
> >> using omap2plus_defconfig with !CONFIG_THUMB2_KERNEL.
> >> Compile tested on OMAP1/2 using omap1_defconfig.
> >>
> >> Signed-off-by: Jean Pihet <j-pihet at ti.com>
> >
> > Acked-by: Kevin Hilman <khilman at ti.com>
> >
> > Boot tested on OMAP1 & OMAP2 as well. Note that neither OMAP1 or OMAP2
> > has had working suspend/resume for a long time now, so I did not test
> > suspend/resume.
>
> For OMAP2:
>
> Tested-by: Kevin Hilman <khilman at ti.com>
>
> to test a little more on OMAP2, I just removed the WFI from the
> low-level code and tested suspend that way. That's enough to be sure
> the copied code is copied and executed.
>
> Worked fine on OMAP2420/n810.
>
> For OMAP1, this didn't work and would require more serious hacking on
> the OMAP1 suspend path, which I currently have no plans to do.
Boots fine on osk5912 and n800 too:
Tested-by: Tony Lindgren <tony at atomide.com>
More information about the linux-arm-kernel
mailing list