[PATCH] mmci: fixup broken_blockend variant patch v2
linus.walleij at linaro.org
Wed Jan 19 15:34:49 EST 2011
2011/1/18 Russell King - ARM Linux <linux at arm.linux.org.uk>:
> How reliable is the FIFOCNT register ?
> What I'm wondering is whether we can get rid of the DATABLOCKEND
> interrupts completely, and instead read the FIFOCNT register to
> discover how many blocks have been successfully transferred. FIFOCNT
> on read gives you the remaining number of words to be transferred into
> the FIFO from the card, not the number of words still to be read by the
> host CPU.
Hmm... the FIFOCNT is just the FIFO.
Do you mean the MMCIDATACNT register? According to the manual
it has exactly that meaning, and is valid "when the data transfer is
complete" which you could assume it to be if you hit an error.
But I'm not betting on it...
Possibly you should add/subtract the words in FIFOCNT too,
but I would say that's a later excercise.
But I think it's a good idea. I'll prep an RFC patch we can test,
we may need some broken cards to test it on though.
> Not sure if that's valid for write atm.
In that specific case you may need to also add the FIFOCNT I
suspect, but I guess we can/will find out.
This approach surely gives better precision than using the blockend
interrupts any day.
I'll hack up something and give it a spin.
I don't know what the purpose of the blockend interrupt really
is, but suspect it may be about reusing ring buffers for MMC
transfers which Linux currently doesn't have need for.
More information about the linux-arm-kernel