[PATCH] drivers: mmc: msm: update to new arm pfn_to_dma API

Daniel Walker dwalker at codeaurora.org
Tue Jan 18 15:22:14 EST 2011

On Tue, 2011-01-18 at 18:28 +0000, Russell King - ARM Linux wrote:
> On Tue, Jan 18, 2011 at 10:04:04AM -0800, Daniel Walker wrote:
> > The page_to_dma() API call was removed. It caused this build
> > failure,
> Because it's an API internal interface.  Don't use it.  Why is this
> driver poking about in API internals all over the place?

If it's internal why is this driver able to call it?

> That is completely broken.  Please use the official APIs - it's not
> hard.  Here's how to do it correctly:

Can you make this into a patch and send it to David Brown ?

> and when you use writel() etc afterwards, those non-cacheable writes to
> box-> will be ordered with your device write.
> So that's a NAK for your original patch.

Are you given us alternative to my fix yet? I didn't see any of your
comments touching that area?



Sent by a consultant of the Qualcomm Innovation Center, Inc.
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum.

More information about the linux-arm-kernel mailing list