[PATCH] omap2-beagle: Depend upon CONFIG_GPIO_TWL4030

Felipe Balbi balbi at ti.com
Mon Jan 17 22:10:39 EST 2011


Hi,

On Mon, Jan 17, 2011 at 04:25:48PM -0500, Ben Gamari wrote:
> Some very basic setup (i.e. MMC) is done in the beagleboard's setup
> callback for the TWL4030's gpio driver, causing a kernel without this
> support to fail to find its root filesystem. I can't imagine why one would
> want to build a kernel for this board without this driver, so I think
> it's worthwhile to explicitly depend on it.
> 
> Signed-Off-By: Ben Gamari <bgamari.foss at gmail.com>
> ---
>  arch/arm/mach-omap2/Kconfig |    1 +
>  1 files changed, 1 insertions(+), 0 deletions(-)
> 
> diff --git a/arch/arm/mach-omap2/Kconfig b/arch/arm/mach-omap2/Kconfig
> index ab784bf..74173f1 100644
> --- a/arch/arm/mach-omap2/Kconfig
> +++ b/arch/arm/mach-omap2/Kconfig
> @@ -120,6 +120,7 @@ config MACH_OMAP_2430SDP
>  config MACH_OMAP3_BEAGLE
>  	bool "OMAP3 BEAGLE board"
>  	depends on ARCH_OMAP3
> +	depends on GPIO_TWL4030
>  	default y
>  	select OMAP_PACKAGE_CBB

NAK. This is totally bogus. The board doesn't really depend on
GPIO_TWL4030, the MMC driver does.

-- 
balbi



More information about the linux-arm-kernel mailing list