[PATCH 1/2] dmaengine: imx-sdma: fix return of sdma_probe()

[Uwe Kleine-König]

If you make the commit log read something like:

  dmaengine: imx-sdma: propagate error in sdma_probe instead of returning 0

you can have my ack.

Uwe

On Mon, Jan 17, 2011 at 10:39:23PM +0800, Shawn Guo wrote:
> Signed-off-by: Shawn Guo <shawn.guo at freescale.com>
> ---
>  drivers/dma/imx-sdma.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/drivers/dma/imx-sdma.c b/drivers/dma/imx-sdma.c
> index d5a5d4d..48d0197 100644
> --- a/drivers/dma/imx-sdma.c
> +++ b/drivers/dma/imx-sdma.c
> @@ -1348,7 +1348,7 @@ err_clk:
>  err_request_region:
>  err_irq:
>  	kfree(sdma);
> -	return 0;
> +	return ret;
>  }
>  
>  static int __exit sdma_remove(struct platform_device *pdev)

-- 
Pengutronix e.K.                           | Uwe Kleine-König            |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |