[PATCH 27/48] ARM: PL08x: avoid duplicating registers in txd and phychan structures

Dan Williams dan.j.williams at intel.com
Sun Jan 16 20:36:57 EST 2011


On Sun, Jan 16, 2011 at 12:18 PM, Russell King - ARM Linux
<linux at arm.linux.org.uk> wrote:
> Subject: [PATCH] ARM: PL08x: cleanup comments
>
> Cleanup the formatting of comments, remove some which don't make sense
> anymore.
>
> Signed-off-by: Russell King <rmk+kernel at arm.linux.org.uk>
> ---
>  drivers/dma/amba-pl08x.c   |  144 ++++++++++++++++----------------------------
>  include/linux/amba/pl08x.h |   45 +++++++-------
>  2 files changed, 72 insertions(+), 117 deletions(-)
>
[..]
> diff --git a/include/linux/amba/pl08x.h b/include/linux/amba/pl08x.h
> index 933b4ed..3111385 100644
> --- a/include/linux/amba/pl08x.h
> +++ b/include/linux/amba/pl08x.h
[..]

Thanks, applied after changing the following hunk...

> @@ -118,8 +116,7 @@ struct pl08x_txd {
>        dma_addr_t dst_addr;
>        size_t len;
>        dma_addr_t llis_bus;
> -       void *llis_va;
> -       bool active;
> +       struct pl08x_lli *llis_va;
>        /* Default cctl value for LLIs */
>        u32 cctl;
>        /*

...to:

@@ -119,7 +117,6 @@ struct pl08x_txd {
        size_t len;
        dma_addr_t llis_bus;
        struct pl08x_lli *llis_va;
-       bool active;
        /* Default cctl value for LLIs */
        u32 cctl;
        /*

--
Dan



More information about the linux-arm-kernel mailing list