[PATCH 27/48] ARM: PL08x: avoid duplicating registers in txd and phychan structures

[Russell King - ARM Linux]

On Fri, Jan 14, 2011 at 05:35:41PM -0800, Dan Williams wrote:
> On Mon, Jan 3, 2011 at 2:39 PM, Russell King - ARM Linux
> <linux at arm.linux.org.uk> wrote:
> > As we now have all the code accessing the phychan {csrc,cdst,clli,cctl,
> > ccfg} members in one function, there's no point storing the data into
> > the struct.  Get rid of the struct members.  Re-order the register dump
> > in the dev_dbg() to reflect the order we write the registers to the DMA
> > device.
> >
> > The txd {csrc,cdst,clli,cctl} values are duplicates of the lli[0]
> > values, so there's no point duplicating these either.  Program the DMAC
> > registers directly from the lli[0] values.
> >
> > Signed-off-by: Russell King <rmk+kernel at arm.linux.org.uk>
> 
> This one caused:
> drivers/dma/amba-pl08x.c: In function 'pl08x_start_txd':
> drivers/dma/amba-pl08x.c:205: warning: dereferencing 'void *' pointer

That probably means you've got something out of order.  I have them
ordered in my git tree, I'll recheck there.