[PATCH v5 08/10] ARM: mxs: add ocotp read function

Uwe Kleine-König u.kleine-koenig at pengutronix.de
Fri Jan 14 04:48:32 EST 2011


Hello Sascha,

On Fri, Jan 14, 2011 at 09:40:09AM +0100, Sascha Hauer wrote:
> On Fri, Jan 14, 2011 at 03:24:54PM +0800, Shawn Guo wrote:
> > +const u32 *mxs_get_ocotp(void)
> > +{
> > + [...]
> > +}
> 
> EXPORT_SYMBOL?
I don't think this should be necessary.  mxs_get_ocotp should only be
called from platform code that cannot (ot at least should not) be
modular.  I suggest to skip it for now and if we really need it later
only add it then.

Best regards
Uwe

-- 
Pengutronix e.K.                           | Uwe Kleine-König            |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |



More information about the linux-arm-kernel mailing list