[PATCH] unbreak ehci-mxc on otg port of i.MX27

[Sascha Hauer]

On Thu, Jan 13, 2011 at 10:06:15AM +0100, Eric Bénard wrote:
> commit 711669e5b80b6f2d88f61ed8a9681f83d8cbd201 fixed port 0 support
> for i.MX51 but broke it for (at least) i.MX27 which doesn't have
> a usb_phy1 clock but has a pdev->id 0.

Shame on me for not reviewing the patch properly :(


> 
> Signed-off-by: Eric Bénard <eric at eukrea.com>
> Cc: Arnaud Patard <arnaud.patard at rtp-net.org>
> Cc: Sascha Hauer <s.hauer at pengutronix.de>
> ---
>  drivers/usb/host/ehci-mxc.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/drivers/usb/host/ehci-mxc.c b/drivers/usb/host/ehci-mxc.c
> index fa59b26..18eb597 100644
> --- a/drivers/usb/host/ehci-mxc.c
> +++ b/drivers/usb/host/ehci-mxc.c
> @@ -178,7 +178,7 @@ static int ehci_mxc_drv_probe(struct platform_device *pdev)
>  	}
>  
>  	/* "dr" device has its own clock */
> -	if (pdev->id == 0) {
> +	if ((cpu_is_mx51()) & (pdev->id == 0)) {

should be && and please remove the unnecessary braces around
cpu_is_mx51(). Otherwise ok.

Sascha

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |