[PATCH 1/2] mach-mmp: MMP2 Drive Strength FAST using wrong value

Eric Miao eric.y.miao at gmail.com
Wed Jan 12 18:03:14 EST 2011


On Fri, Jan 7, 2011 at 1:26 PM, Philip Rakity <prakity at marvell.com> wrote:
>
> Drive strength for MMP2 is a 2 bit value but because of the mapping in
> plat-pxa/mfp.h needs to be shifted up one bit to handle real
> location in mfp registers.  (MMP2 and PXA910 drive strength start
> at bit 11 while PXA168 starts at bit 10).
>
> Values 0, 1, 2, and 3 effectively need to be
> 0, 2, 4, and 6 to fit into register.  8 does not work.
>
> Signed-off-by: Philip Rakity <prakity at marvell.com>
> Tested-by: John Watlington <wad at laptop.org>

Applied.

> ---
>  arch/arm/mach-mmp/include/mach/mfp-mmp2.h |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/arch/arm/mach-mmp/include/mach/mfp-mmp2.h b/arch/arm/mach-mmp/include/mach/mfp-mmp2.h
> index 117e303..4ad3862 100644
> --- a/arch/arm/mach-mmp/include/mach/mfp-mmp2.h
> +++ b/arch/arm/mach-mmp/include/mach/mfp-mmp2.h
> @@ -6,7 +6,7 @@
>  #define MFP_DRIVE_VERY_SLOW    (0x0 << 13)
>  #define MFP_DRIVE_SLOW         (0x2 << 13)
>  #define MFP_DRIVE_MEDIUM       (0x4 << 13)
> -#define MFP_DRIVE_FAST         (0x8 << 13)
> +#define MFP_DRIVE_FAST         (0x6 << 13)
>
>  /* GPIO */
>  #define GPIO0_GPIO     MFP_CFG(GPIO0, AF0)
> --
> 1.7.0.4
>
>
>
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel at lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
>



More information about the linux-arm-kernel mailing list