[PATCH 2/2] ARM i.MX53 enable LOCO board bootup

Yong Shen yong.shen at linaro.org
Tue Jan 11 21:46:24 EST 2011


Hi Fabio,

Below is my reply to Baruch, I meant to keep this code here to show
the reset process clearly.
>> +     if (ret) {
>> +             printk(KERN_ERR"failed to get GPIO_FEC_PHY_RESET: %d\n", ret);
>> +             return;
>> +     }
>> +     gpio_direction_output(SMD_FEC_PHY_RST, 0);
>> +     gpio_set_value(SMD_FEC_PHY_RST, 0);
>
> This seems to be redundant. gpio_direction_output() has already set the value
> to 0.

You are right. But, gpio_set_value is meant to be here to show the
process of fec reset: first pull low and then pull high. And
gpio_direction_output here is for direction configuration although it
has the ability of configure output value.

thanks
Yong



More information about the linux-arm-kernel mailing list