[PATCH 1/2] serial: Add auart driver for i.MX23/28

Sascha Hauer s.hauer at pengutronix.de
Tue Jan 11 12:57:04 EST 2011


On Tue, Jan 11, 2011 at 06:10:50PM +0100, Wolfram Sang wrote:
> On Tue, Jan 11, 2011 at 04:09:04PM +0100, Sascha Hauer wrote:
> [...]
> > +#include <asm/cacheflush.h>
> > +#include <mach/mx28.h>
> 
> What about MX23 and STMP3xxx?

This include is not needed, will remove. Instead we need linux/io.h.

> 
> > +
> > +#define MXS_AUART_PORTS 5
> 
> MX23 has just 2. We should better adapt to that depending on the type?

This is just the maximum number the driver supports, it's safe to keep
it as is.

Sascha


-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |



More information about the linux-arm-kernel mailing list