[PATCH] TWD: enable one-shot mode

Russell King - ARM Linux linux at arm.linux.org.uk
Tue Jan 11 06:52:09 EST 2011


On Mon, Jan 10, 2011 at 09:12:36PM -0800, Stephen Boyd wrote:
> On 12/24/2010 11:18 AM, Russell King - ARM Linux wrote:
> > Allow one shot timer mode to be used with the TWD.  This allows
> > NOHZ mode to be used on SMP systems using the TWD localtimer.
> >
> > Tested on Versatile Express.
> >
> > Signed-off-by: Russell King <rmk+kernel at arm.linux.org.uk>
> > ---
> > Acks/Tested-by's would be appreciated, thanks.
> >
> 
> I see this patch was already tested and merged but can you elaborate on
> why this was done? From what I understand, NOHZ selects one-shot (like
> is done in this patch), so why don't the machines with a TWD choose NOHZ
> or high res timers?

You're right - so it's not actually required.  It should probably be
reverted, though it does no damage...



More information about the linux-arm-kernel mailing list